fix: Use var.typeStr metadata for type coercion in _caput#872
Open
fix: Use var.typeStr metadata for type coercion in _caput#872
Conversation
…var.value() Extract a reusable coerce_value_for_var helper that uses rogue variable metadata (typeStr) to determine expected types, replacing the var.value() read-based type discovery. Also replaces deprecated np.uint calls with np.uint64. Closes #853
Collaborator
|
The list of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coerce_value_for_var(var, val)helper intools.pythat usesvar.typeStrmetadata to determine expected types, replacing thevar.value()read-based type discovery in_caputTYPEMAPdict mapping all 12 standard Rogue 6typeStrvalues to Python/numpy typesnp.uintcall sites insmurf_command.pywithnp.uint64Test plan
flake8 --count python/passes with zero errors_caputenum branch (var.enum is not None) and command branch (var.isCommand) are unchangedCloses #853